DatafariUI - cannot overwrite saved query
When saving a query, if it has the same name as an existing one, when clicking save, the new one is silently discarded and datafari keeps the previous one only. Would be better to at least have a warning or an error message.
Activity
- Cédric changed milestone to %Datafari 5.2
changed milestone to %Datafari 5.2
- Cédric added bug comp - ui priority 2 labels
added bug comp - ui priority 2 labels
- Developer
The overwrite is allowed by the back ? or it is just a control in front side ?
What behavior do you want :
- Control in front to display a warning and change the name before saving
- Save the new one anyway and display a warning message that the old one is overwritten
Edited by Jérémy KHO - Jérémy KHO changed time estimate to 1d
changed time estimate to 1d
- Cédric marked this issue as related to #633 (closed)
marked this issue as related to #633 (closed)
- Jérémy KHO mentioned in commit DatafariUI@3855558e
mentioned in commit DatafariUI@3855558e
- Developer
- Jérémy KHO mentioned in commit DatafariUI@daa2133d
mentioned in commit DatafariUI@daa2133d
- Developer
Pushed, have to test!
Just tested with firefox, edge and opera, using commitdaa2133 and I have the same issue: when I'm not logged in, I can see the search UI and the date facet is correct (I configured it to see only the children), but once I authenticate, I get an empty screen. Looking at the console, I get this:
fn ModifySavedQueryModal.js:81 React 2 unstable_runWithPriority scheduler.production.min.js:19 React 4 unstable_runWithPriority scheduler.production.min.js:19 React 5 e useHttp.js:74 u runtime.js:45 _invoke runtime.js:274 t runtime.js:97 Babel 2 react-dom.production.min.js:209:194 React 5 unstable_runWithPriority scheduler.production.min.js:19 React 4 unstable_runWithPriority scheduler.production.min.js:19 React 5 e useHttp.js:74 u runtime.js:45 _invoke runtime.js:274 t runtime.js:97 Babel 2```
- Developer
I pushed a fix. The returned value from saved queries fetch was not what I expected.
- Please register or sign in to reply
- Jérémy KHO mentioned in commit DatafariUI@80e0f495
mentioned in commit DatafariUI@80e0f495
- Cédric closed
closed